Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(plugin): support ordering #82

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Leopoldthecoder
Copy link
Member

@Leopoldthecoder Leopoldthecoder commented Aug 21, 2023

Summary

Adds support for plugin ordering.

Issue reference

Fix #[issue number]

@Leopoldthecoder Leopoldthecoder marked this pull request as ready for review August 24, 2023 09:02
export const formatVersion = (version: string) => {
return version.substring(0, (version.indexOf('-') > -1 && version.indexOf('-')) || version.length).split('.').slice(0, 2).join('.')
}

export function getMessageFromError (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this getMessageFromError rename to getErrorMessage well? what do you think?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think both names are acceptable: they are not quite different from each other in terms of meaning.

raoxiaoyan
raoxiaoyan previously approved these changes Aug 24, 2023
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this file in the directory /spec-ee

@raoxiaoyan raoxiaoyan self-requested a review August 24, 2023 13:35
@raoxiaoyan raoxiaoyan marked this pull request as draft October 19, 2023 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants